Fix face.color is undefined in SoftwareRender.drawTriangle #8036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob
added a commit
that referenced
this pull request
Jan 29, 2016
Fix face.color is undefined in SoftwareRender.drawTriangle
|
Thanks! |
| @@ -713,7 +713,8 @@ THREE.SoftwareRenderer = function ( parameters ) { | |||
| mpUV12 = new THREE.Vector2(), | |||
| mpUV23 = new THREE.Vector2(), | |||
| mpUV31 = new THREE.Vector2(), | |||
| tempFace = { vertexNormalsModel : [] }; | |||
| tempFace = { vertexNormalsModel : [] | |||
| , color : { r: face.color.r, g: face.color.b, b: face.color.b } }; | |||
There was a problem hiding this comment.
@daoshengmu you could perhaps just do color: face.color, since it is not modified, therefor saving some memory?
There was a problem hiding this comment.
in fact, a bunch of new THREE.Vector-s above could also be done once somewhere outside, probably...
|
@makc. Yep, tempFace = { vertexNormalsModel : [], color : face.color }; should be better. I will send another PR to fix this. As you mentioned, a bunch of new THREE.Vector-s is not good for performance. In the previous version of SoftwareRenderer that I modified, the performance issue is happened there. I can give a help to this part as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve bug #7997