Removed deprecated THREE.ImageUtils.loadTexture in all examples and docs #7988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| textures[ i ] = THREE.ImageUtils.loadTexture( baseUrl + textureUrls[ i ], mapping, checkLoadingComplete ); | ||
|
|
||
| textures[ i ] = new THREE.TextureLoader().load( baseUrl + textureUrls[ i ], checkLoadingComplete ); |
There was a problem hiding this comment.
Are multiple instances of the loader required for some reason?
|
Yay! Thanks for this. |
@WestLangley No, they are not necessary 😉. Good suggestion! The new commit ensures that the concerned functions create one textureLoader and re-use it in their loops. |
mrdoob
added a commit
that referenced
this pull request
Jan 18, 2016
Removed deprecated THREE.ImageUtils.loadTexture in all examples and docs
|
Maaany thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bye-bye THREE.ImageUtils! This PR changes the following in all examples and docs:
THREE.ImageUtils.loadTexture->THREE.TextureLoaderI've tested each single example with the new code.
Three.Legacy.jsshould now be the only file that contains legacyTHREE.ImageUtilscode.