Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor example: webgl_shading_physical #7973

Merged
merged 1 commit into from
Jan 15, 2016
Merged

Refactor example: webgl_shading_physical #7973

merged 1 commit into from
Jan 15, 2016

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 15, 2016

I am declaring WAR on legacy code! This PR cleans up and fixes the webgl_shading_physical.html.

  • THREE.ImageUtils.loadTexture-> THREE.TextureLoader
  • THREE.ImageUtils.loadTextureCube-> THREE. CubeTextureLoader
  • shadowCameraVisible -> THREE.CameraHelper
  • enhanced dat.GUI for daylight controls instead of using a key code
  • fixed width of dat.GUI so you see the entire labels now
  • removed unused code (see materialCube)

@mrdoob
Copy link
Owner

mrdoob commented Jan 15, 2016

I am declaring WAR on legacy code!

YES!

mrdoob added a commit that referenced this pull request Jan 15, 2016
@mrdoob
Merge pull request #7973 from Mugen87/dev
16df8f4 
Refactor example: webgl_shading_physical
@mrdoob mrdoob merged commit 16df8f4 into mrdoob:dev Jan 15, 2016
@mrdoob
Copy link
Owner

mrdoob commented Jan 15, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @mrdoob