Lathe geometry in the editor #7971
Merged
+168
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a minimal support of lathe geometry in the editor.
|
Super nice! Thanks! |
|
Do you think |
|
The first time I use the function, I thought it will revolve on the Y axis. If the function is refactored, maybe the points should be Vector2 and a parameter should be added to choose the axe. By axe, I mean X, Y or Z. In my own version of the editor, I rotate the mesh because I think it’s more natural. |
|
It is a breaking change but it's easy to warn the user though (checking for |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a minimal support of lathe geometry in the editor.