-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added general purpose particle system example: campfire. #7841
Conversation
Looks great! Is https://github.com/mkkellogg/ParticleSystemJS the main page for it? If so we should probably link to it somewhere (either source or example). |
Yes, https://github.com/mkkellogg/ParticleSystemJS is the main page, I can make a quick update to the example page with a link. The code for the particle systems is currently contained in 5 different files, should I package them up into a single file and minify them for the example or leave them as they are in the source repo? |
It depends of how you want the code to be managed. If you want to make sure there are no multiple versions of the code, then it's better to add here a minified file as a library and point to |
Ok, I have updated the PR with the particle system source packaged into a single minified library file called GeneralParticleSystem.min.js. |
Added general purpose particle system example: campfire.
Thanks! |
Now that this had become its own library, how about giving it a name? Say... flecks?
That way it's easier to use (less code to write), it has its own namespace so it can be simplified and it's also less THREE namespace pollution (and possible collision). What do you think? |
Ah, that's a good idea. "Flecks" is a good name, but I was also thinking about possibly naming it "Photons". I will give the name a little more thought and then I will make the update. |
Yay! |
Ok, I have renamed the name-space to "PHOTONS" and I have included the minified version under examples/js/libs. The new PR is ready to go: #7927 |
General Purpose Particle System - There are a number of other particle system examples on the Three.js site, but the aim of this one is to be more general purpose, extendable, and to support texture animations. This campfire example includes three systems: fire, smoke, and embers. Example page is at examples/particles/general.