Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename TimeNode to ClockNode #7818

Merged
merged 2 commits into from
Dec 19, 2015
Merged

rename TimeNode to ClockNode #7818

merged 2 commits into from
Dec 19, 2015

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 18, 2015

Another conceptual change... I think it is more in keeping with Three.JS style?

@mrdoob
Copy link
Owner

mrdoob commented Dec 19, 2015

I actually would prefer TimerNode. I never liked Clock.

@sunag
Copy link
Collaborator Author

sunag commented Dec 19, 2015

Hmm, I renamed TimeNode to TimerNode can be it? or we will leave as it was TimeNode

mrdoob added a commit that referenced this pull request Dec 19, 2015
@mrdoob
Merge pull request #7818 from sunag/dev
fd61eb4 
rename TimeNode to ClockNode
@mrdoob mrdoob merged commit fd61eb4 into mrdoob:dev Dec 19, 2015
@mrdoob
Copy link
Owner

mrdoob commented Dec 19, 2015

Perfect! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunag @mrdoob