Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disney roughness reparameterization #7420

Closed

Conversation

bhouston
Copy link
Contributor

This PR is built upon the cosine cubemap LOD PR: #7414

I have removed the restriction of the Physical materials roughness parameterization to just [0.5 to 1], rather allowing it to vary between [0.04, 1] like the roughness parameterization in UE4. (The lower limit of 0.04 is required to avoid some divide by zeros.) This allows one to make perfectly shiny mirrors and other perfectly polished metals.

… to set those values. still missing some glue code.
@mrdoob
Copy link
Owner

mrdoob commented Oct 26, 2015

@WestLangley thoughts?

@WestLangley
Copy link
Collaborator

We need to address this issue after the dev branch is working again.

It seems unlikely to me that Disney would get this wrong, but we will see.

In any event, in the API, roughness ranges from zero to 1. The objective is to make roughness "perceptually linear" over that range. So, the [ 0, 1 ] input is remapped in the shader so we get the perceptually linear result we want.

@bhouston
Copy link
Contributor Author

I do not change the linearity, I just extended the range. If something isn't compiling I can look into it.

@WestLangley
Copy link
Collaborator

I think the commit that is the topic of this PR is bhouston@e7db59e

That change is fine with me.

mrdoob added a commit that referenced this pull request Nov 13, 2015
@mrdoob
Copy link
Owner

mrdoob commented Nov 13, 2015

Thanks guys!

@mrdoob mrdoob closed this Nov 13, 2015
@mrdoob
Copy link
Owner

mrdoob commented Nov 13, 2015

I've been playing with the new material and I was starting to notice that the sharper material I was able to achieve was metal. This change brings many more possibilities indeed!

@mrdoob
Copy link
Owner

mrdoob commented Nov 13, 2015

By the way... Seems like when I use metalnessMap, metalness has no effect. But when using rougnessMap, roughness still has effect. Is this the exected behaviour?

@WestLangley
Copy link
Collaborator

We can change the behavior so metalnessMap modulates metalness. That would be consistent with how the other maps are handled.

Or we can change how roughness is handled.

It is up to you.

@mrdoob
Copy link
Owner

mrdoob commented Nov 13, 2015

I think I vote for metalnessMap modulating metalness. Just like map modulates color.

@WestLangley
Copy link
Collaborator

OK. I'll take care of it.

@mrdoob
Copy link
Owner

mrdoob commented Nov 13, 2015

Thanks!

@bhouston bhouston deleted the removeDisneyRoughnessReparameterization branch May 12, 2017 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants