Multitouch fix for TrackballControls #7406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for mrdoob#7185. After using two fingers, the camera would rapidly rotate if both fingers were not removed simultaneously. Adding in some state checks in `touchmove` and `touchend` prevents the jump from the null `_movePrev`, allowing users to quickly go from zooming and panning to rotating.
mrdoob
added a commit
that referenced
this pull request
Oct 22, 2015
Multitouch fix for TrackballControls
|
Thanks! |
mrdoob
added a commit
that referenced
this pull request
Oct 22, 2015
|
@shshaw I've refactored |
|
Getting some oddities when I use 3 fingers then take one off, likely related to the Also, the conditional on Will play with it some more to see if I can isolate it. |
Thanks! |
shshaw
added a commit
to shshaw/three.js
that referenced
this pull request
Oct 22, 2015
* Removed unnecessary `default` case for two or more touches on `touchend` to prevent issues with 3 or more touches. * Reset zoom distances on `case 0` and `case 1`. I couldn't combine them easily without doing a separate `if` statement. * Simplified `case 1` action to set `_moveCurr` and `_movePrev` to the current touch position preventing camera jumping next time `touchmove` is called. Related to issue mrdoob#7185 and pull request mrdoob#7406
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #7185. After using two fingers, the camera would rapidly rotate if both fingers were not removed simultaneously. Adding in a state check in
touchendprevents the jump from the null_movePrev, allowing users to quickly go from zooming and panning to rotating.