Make readRenderTargetPixels() work with implementation defined formats #7226
Conversation
…formats We have to bind the buffer before making the test, because the answer is circumstantial ( https://www.khronos.org/registry/webgl/specs/1.0/#readpixels ). Did you know that with the OES_texture_float extension Chrome allows rendering to a float texture then reading a float render target to a Float32ArrayBuffer in readPixels() ?
|
Firefox does the same with WEBGL_color_buffer_float |
Make readRenderTargetPixels() work with implementation defined formats
|
Thanks! |
|
It's tangentially touching the issue of the WEBGL_color_buffer_float extension (needed for firefox), do you have an opinion on how to handle it? It's a bit of a mess, I think the algorithm before accepting a user submitted Float RenderTarget would be to try to find and load OES_texture_float (mandatory) then WEBGL_color_buffer_float (optional, carry on if not found), then directly bind the buffer, and look if we could could complete or not. (firefox will complete the binding without the extension, but it won't allow for readPixels() in float buffers when it's read time). here are the relevants links: |
|
Maybe we can do something like this? |
the renderTarget.texture was forgotten and I enjoyed the edit to integrate that too: mrdoob#7226 (I can't find an editor were I can comfortably and safely 3-way hand merge a 4kloc file, so I just copy-paste)
We have to bind the buffer before doing the test, because the answer is circumstantial ( https://www.khronos.org/registry/webgl/specs/1.0/#readpixels ).
Did you know that with the OES_texture_float extension Chrome allows rendering to a float texture then reading a float render target to a Float32ArrayBuffer in readPixels() ?