-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fix: clear angle divisor for all geometries if instancing is used. #7225
Conversation
/ping @benaadams |
Definately bug here; but the divisor reset should probably go in WebGLState, probably enableAttribute should take note of the divisor if set; and then reset back to 0 if not specified and changed > 0? |
@benaadams I tried to do what you said in the 2nd commit. Note: If I set state.usedInstancedBufferCount to 0 again after resetting then it did not work. |
|
||
var extension = extensions.get( 'ANGLE_instanced_arrays' ); | ||
|
||
if ( extension != null ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect we don't need this check. We can assume it's available if usedInstancedBufferCount
is not 0...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Fixed.
Does This does fix the issue but should be able to cut down the gpu comms a little more; having a look into it. |
This work better? #7230 |
@benaadams Unfortunately your patch #7230 shows the same problem as without it.. |
Oh wait, I might have checked out the wrong branch.. just a sec |
@benaadams It works now :) |
This fixes the issue I mentioned in #5171 : when angle instancing is used together with regular geometries, there are strange problems, for example objects that do not render or textures are uniformly coloured by one of its pixel values.
I am not sure if this is the best way to fix it, but at least it works for now.