Blender: Index buffer #7221
Merged
Blender: Index buffer #7221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moar thanks! |
tschw
referenced
this pull request
in tschw/three.js
Sep 22, 2015
|
Great you're getting on top of that code and fixed it! Looks like the same code as in a4e892b... Also has to happen in another place, I guess? Clueless now, more than a year later - and not enough time to dig into it, really. Technically would've been my previous PR that added indexed exports in the first place, then. I wouldn't have known, and that PR had a review, so should've been noticed by someone who had 😇 |
Yeah, seems like there are 2 code paths, one when exporting a single geometry and another when exporting a scene. I've unified it a bit in the refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.