Sky Shader Example Clean Up

[WestLangley]

mrdoobapproves formatting, switched to OrbitControls, removed animation loop.

[mrdoob]

Nice!

[mrdoob]

Thanks!

What do you think about adding requestAnimationFrame inside the controls directly so the user doesn't have to worry about calling .update()?

[WestLangley]

It would be nice if we could improve the API. Users almost always get this wrong -- especially since TrackballControls is different. Here is a summary.

If there is no animation loop, then only this line is required.

controls.addEventListener( 'change', render ); // add this only if there is no animation loop

If there is an animation loop, and controls damping or auto-rotation is desired, then only this line is required.

controls.update(); // required if controls.enableDamping = true, or if controls.autoRotate = true

Otherwise, neither pattern is required.

[mrdoob]

Yeah... That's too much to know I think... If we added rAF to all the controls there would only be two cases:

1. There is an animation loop. The user doesn't need to do anything.
2. There is no animation loop. The user will need to add controls.addEventListener( 'change', render );

[WestLangley]

And update() would no longer need to be exposed.

[mrdoob]

Yep!