Add unit test for Object3D and Camera #7114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tWorldQuaternion. Also add a unittest for camera lookAt
|
see #7108 |
|
|
||
| // get a reference object for comparing | ||
| var reference = obj.rotateOnAxis(new THREE.Vector3(1, 0, 0), 45).rotation; | ||
| obj.rotateX(45); |
There was a problem hiding this comment.
rotateX() calls rotateOnAxis(). You are not actually testing anything here.
This appears to be an issue throughout this PR.
Also, Euler rotations are not unique. I do not think it is wise to compare them. Perhaps comparing the quaternions is best. But even so, the negation of a unit quaternion represents the same rotation.
|
@simonThiele Thank you for working on the unit tests. It is important! |
|
Do you mind going a "Indent spaces to tabs" in these files? We try to use tabs for indenting. |
|
yep, using tabs now. |
| var obj = new THREE.Object3D(); | ||
|
|
||
| obj.lookAt(new THREE.Vector3(0, -1, 1)); | ||
| ok( obj.getWorldRotation().x * RadToDeg === 45 , "x is equal" ); |
There was a problem hiding this comment.
getWorldRotation() or getWorldQuaternion()?
There was a problem hiding this comment.
getWorldQuaternion! thx
mrdoob
added a commit
that referenced
this pull request
Sep 7, 2015
Add unit test for Object3D and Camera
|
Sweet! Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed last evening here is the PR with some unit tests for Object3D.