Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDSLoader: Verify all faces of cubemap #7091

Merged
merged 1 commit into from
Sep 2, 2015
Merged

DDSLoader: Verify all faces of cubemap #7091

merged 1 commit into from
Sep 2, 2015

Conversation

nopjia
Copy link
Contributor

@nopjia nopjia commented Sep 2, 2015

  • Implemented the TODO comment
  • Few minor javascript fixes

@mrdoob
Copy link
Owner

mrdoob commented Sep 2, 2015

Looks good!

mrdoob added a commit that referenced this pull request Sep 2, 2015
@mrdoob
Merge pull request #7091 from nopjia/dev
df6c2f9 
DDSLoader: Verify all faces of cubemap
@mrdoob mrdoob merged commit df6c2f9 into mrdoob:dev Sep 2, 2015
@mrdoob
Copy link
Owner

mrdoob commented Sep 2, 2015

Thanks!

@nopjia
Copy link
Contributor Author

nopjia commented Sep 2, 2015

Hooray! First three.js contribution. Thanks!

@nopjia nopjia deleted the dev branch September 2, 2015 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nopjia @mrdoob