Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeUtils: Add getDataFromObject() #30171

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 20, 2024

Related issue: #30161 (comment)

Description

Gets the object data that can be shared between different rendering steps.

@sunag sunag added this to the r172 milestone Dec 20, 2024
@sunag sunag changed the title NodeUtils: Added getDataFromObject NodeUtils: Added getDataFromObject() Dec 20, 2024
Copy link

github-actions bot commented Dec 20, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.4
79.05
339.4
79.05
+0 B
+0 B
WebGPU 486.93
135.03
487
135.07
+71 B
+40 B
WebGPU Nodes 486.39
134.95
486.46
134.99
+71 B
+35 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.3
112.11
465.3
112.11
+0 B
+0 B
WebGPU 557.13
150.77
557.18
150.77
+50 B
+2 B
WebGPU Nodes 513.2
140.53
513.25
140.55
+50 B
+22 B

@sunag sunag changed the title NodeUtils: Added getDataFromObject() NodeUtils: Add getDataFromObject() Dec 20, 2024
@sunag sunag marked this pull request as ready for review December 20, 2024 03:49
@sunag sunag merged commit 083f233 into mrdoob:dev Dec 20, 2024
12 checks passed
@sunag sunag deleted the dev-skinning-velocity-1 branch December 20, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant