Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL: Vertex shader revision 2 #30147

Merged
merged 2 commits into from
Dec 17, 2024
Merged

TSL: Vertex shader revision 2 #30147

merged 2 commits into from
Dec 17, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 17, 2024

Related issue: #30108

Description

Add a setupModelViewProjection() interface to allow extended materials to manipulate the MVP if needed.

Copy link

github-actions bot commented Dec 17, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.21
79.01
339.21
79.01
+0 B
+0 B
WebGPU 486.37
134.95
486.55
134.98
+178 B
+36 B
WebGPU Nodes 485.84
134.85
486.02
134.88
+178 B
+36 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.1
112.07
465.1
112.07
+0 B
+0 B
WebGPU 555.5
150.38
555.67
150.42
+178 B
+39 B
WebGPU Nodes 511.4
140.12
511.57
140.14
+168 B
+27 B

@sunag sunag marked this pull request as ready for review December 17, 2024 19:24
@sunag sunag added this to the r172 milestone Dec 17, 2024
@sunag sunag merged commit 94ad822 into mrdoob:dev Dec 17, 2024
12 checks passed
@sunag sunag deleted the dev-rev-2 branch December 17, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant