Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Improve Material page (en/fr) #30118

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Docs: Improve Material page (en/fr) #30118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23613b8
Docs: Add TSL example for the onBeforeCompile method in Material
borisghidaglia Dec 13, 2024
e858c5d
Implements review feedbacks
borisghidaglia Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/api/en/materials/Material.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,9 @@ <h3>
<p>
An optional callback that is executed immediately before the shader
program is compiled. This function is called with the shader source code
as a parameter. Useful for the modification of built-in materials.
as a parameter. Useful for the modification of built-in materials, but the
recommended approach moving forward is to use `WebGPURenderer` with the new
Node Material system and [link:https://github.com/mrdoob/three.js/wiki/Three.js-Shading-Language TSL].
</p>
<p>
Unlike properties, the callback is not supported by [page:Material.clone .clone](),
Expand Down
4 changes: 3 additions & 1 deletion docs/api/fr/materials/Material.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,9 @@ <h3>[method:undefined dispose]()</h3>
<h3>[method:undefined onBeforeCompile]( [param:Shader shader], [param:WebGLRenderer renderer] )</h3>
<p>
Un callback facultatif qui est exécuté immédiatement avant la compilation du programme shader.
Cette fonction est appelée avec le code source du shader comme paramètre. Utile pour la modification des matériaux intégrés.
Cette fonction est appelée avec le code source du shader comme paramètre. Utile pour la modification des matériaux intégrés,
bien que la nouvelle méthode recommandée soit d'utiliser `WebGPURenderer` avec le nouveau système de Node Material et
Mugen87 marked this conversation as resolved.
Show resolved Hide resolved
[link:https://github.com/mrdoob/three.js/wiki/Three.js-Shading-Language TSL].
</p>
<p>
Contrairement aux propriétés, le callback n'est pas pris en charge par [page:Material.clone .clone](), [page:Material.copy .copy]() et [page:Material.toJSON .toJSON]().
Expand Down
Loading