Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSL: Add texture_depth_multisampled_2d for wgslFn #30082

Merged
merged 9 commits into from
Dec 11, 2024
Merged

TSL: Add texture_depth_multisampled_2d for wgslFn #30082

merged 9 commits into from
Dec 11, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 10, 2024 •
edited
Loading

@sunag sunag changed the title Dev depth rev TSL: Add next() Dec 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.21
79.01		 339.21
79.01		 +0 B
+0 B
WebGPU 485.91
134.87		 485.96
134.87		 +49 B
+0 B
WebGPU Nodes 485.38
134.77		 485.43
134.77		 +49 B
-1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.1
112.06		 465.1
112.06		 +0 B
+0 B
WebGPU 555.02
150.3		 555.07
150.31		 +45 B
+4 B
WebGPU Nodes 510.87
140.01		 510.92
140.02		 +45 B
+4 B

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 10, 2024
View reviewed changes
src/nodes/core/NextNode.js Fixed Show fixed Hide fixed
@sunag sunag mentioned this pull request Dec 10, 2024
Closed
@sunag sunag added this to the r172 milestone Dec 10, 2024
@sunag sunag marked this pull request as ready for review December 10, 2024 03:53
@sunag sunag changed the title TSL: Add next() TSL: Add 'texture_depth_multisampled_2d' for wgslFn Dec 11, 2024
@sunag sunag changed the title TSL: Add 'texture_depth_multisampled_2d' for wgslFn TSL: Add texture_depth_multisampled_2d for wgslFn Dec 11, 2024
@sunag sunag merged commit 80b7991 into mrdoob:dev Dec 11, 2024
12 checks passed
@sunag sunag deleted the dev-depth-rev branch December 11, 2024 17:39
This was referenced Dec 15, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r172
Development

Successfully merging this pull request may close these issues.

Depth textures are consistently read as 0 in compute shaders
1 participant
@sunag