Node: Document more modules. #30067
Merged
Node: Document more modules. #30067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Dec 8, 2024
| @@ -65,11 +106,11 @@ class RangeNode extends Node { | |||
| max.setScalar( 0 ); | |||
|
|
|||
| if ( minLength === 1 ) min.setScalar( minValue ); | |||
| else if ( minValue.isColor ) min.set( minValue.r, minValue.g, minValue.b ); | |||
| else if ( minValue.isColor ) min.set( minValue.r, minValue.g, minValue.b, 1 ); | |||
There was a problem hiding this comment.
@sunag This is a minor fix to prevent NaN values in the attribute. Vector4.set() should always be used with four arguments otherwise properties end up undefined and then produce garbage values in subsequent computations.
Since the code assumes a four-component color value, 1 is used so alpha gets 1.
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #29984
Description
More documentation.