Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShadowBaseNode: Fix CSM shadowWorldPosition #30060

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 7, 2024

Related issue: Fixes #30053, #29921

Description

  • Add ShadowBaseNode
  • Fix CSM shadowWorldPosition

@sunag sunag added this to the r172 milestone Dec 7, 2024
Copy link

github-actions bot commented Dec 7, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.11
78.98
339.11
78.98
+0 B
+0 B
WebGPU 485.65
134.83
485.86
134.87
+208 B
+43 B
WebGPU Nodes 485.12
134.73
485.33
134.78
+208 B
+44 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465
112.04
465
112.04
+0 B
+0 B
WebGPU 555.05
150.28
555.23
150.32
+187 B
+43 B
WebGPU Nodes 510.93
140
511.12
140.04
+187 B
+44 B

@sunag sunag marked this pull request as ready for review December 7, 2024 19:25
@sunag sunag merged commit f5f25c3 into mrdoob:dev Dec 7, 2024
12 checks passed
@sunag sunag deleted the dev-shadows-fix branch December 7, 2024 19:25
Methuselah96 added a commit to Methuselah96/three.js that referenced this pull request Dec 15, 2024
I think this is missing from mrdoob#30060?
sunag pushed a commit that referenced this pull request Dec 16, 2024
* Export shadowWorldPosition from TSL

I think this is missing from #30060?

* Single quotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSM Shadows broken
1 participant