Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeBuilder: More docs. #30025

Merged
merged 1 commit into from
Dec 3, 2024
Merged

NodeBuilder: More docs. #30025

merged 1 commit into from
Dec 3, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 3, 2024

Related issue: #29984

Description

@sunag I have finalized the JSDoc for NodeBuilder however I was not able to document the flow, stack and chaining related logic to full extend (types and signatures are defined though). It would be great if you can revisit this bit at some point and resolve the TODOs.

Copy link

github-actions bot commented Dec 3, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.11
78.98
339.11
78.98
+0 B
+0 B
WebGPU 484.6
134.48
484.6
134.47
+0 B
-1 B
WebGPU Nodes 484.06
134.38
484.06
134.38
+0 B
-1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.62
111.98
464.62
111.98
+0 B
+0 B
WebGPU 553.55
149.82
553.55
149.82
+0 B
+0 B
WebGPU Nodes 509.43
139.53
509.43
139.53
+0 B
-1 B

@Mugen87 Mugen87 added this to the r172 milestone Dec 3, 2024
@Mugen87 Mugen87 merged commit 0c45156 into mrdoob:dev Dec 3, 2024
12 checks passed
@sunag sunag mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant