Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDSLoader: Add 24bit uncompressed RGB support. #30010

Merged
merged 9 commits into from
Dec 2, 2024
Merged

Conversation

sam6321
Copy link
Contributor

@sam6321 sam6321 commented Dec 2, 2024

Description

Adds support for 24bit uncompressed RGB textures to DDSLoader. The texture data is read from the file in RGB, and returned in RGBA format with a=1.

I came across a bumpmap texture that was using this format that could not be parsed by DDSLoader. I've attached the texture for reference.

wave_normals.zip

Adds support for 24bit uncompressed RGB textured to DDSLoader.
The texture data is read from the file in RGB, and returned in RGBA format with a=1.
@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 2, 2024

Interesting. Do you mind updating the webgl_loader_texture_dds and use such a 24 bit texture so we have a test case for validation?

@sam6321 sam6321 changed the base branch from master to dev December 2, 2024 12:17
@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 2, 2024

To make the CI work, you have to regenerate the examples E2E screenshot via:

npm run make-screenshot webgl_loader_texture_dds

Besides, please revert the changes to package-lock.json (if the revert troubles you, copy the contents from dev into your branch).

@sam6321
Copy link
Contributor Author

sam6321 commented Dec 2, 2024

I don't understand why those changes are there, I've checked out that file multiple times from dev and it's still showing changes.
Should be fixed now.

I'll re-generate the examples

@Mugen87 Mugen87 added this to the r172 milestone Dec 2, 2024
@Mugen87 Mugen87 merged commit 45b953d into mrdoob:dev Dec 2, 2024
10 checks passed
@Mugen87 Mugen87 changed the title Add 24bit uncompressed RGB support to DDSLoader DDSLoader: Add 24bit uncompressed RGB support. Dec 2, 2024
@sam6321 sam6321 deleted the patch-2 branch December 3, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants