-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDSLoader: Add 24bit uncompressed RGB support. #30010
Conversation
Adds support for 24bit uncompressed RGB textured to DDSLoader. The texture data is read from the file in RGB, and returned in RGBA format with a=1.
Interesting. Do you mind updating the webgl_loader_texture_dds and use such a 24 bit texture so we have a test case for validation? |
To make the CI work, you have to regenerate the examples E2E screenshot via:
Besides, please revert the changes to |
I'll re-generate the examples |
Clean up.
Description
Adds support for 24bit uncompressed RGB textures to DDSLoader. The texture data is read from the file in RGB, and returned in RGBA format with a=1.
I came across a bumpmap texture that was using this format that could not be parsed by DDSLoader. I've attached the texture for reference.
wave_normals.zip