RectAreaLightNode: Fix update()
.
#29771
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
The PR fixes a bug in
RectAreaLightNode
that appears when you produce a frame with more than onerender()
call and different cameras. My use case was updating aCubeCamera
per frame and using its cube render target as a texture for objects.The default update type of analytical light nodes in
FRAME
. This is fine for most modules butRectAreaLightNode
depends on the view matrix in itsupdate()
method. If there is only a single update per frame,RectAreaLightNode
uses wrong uniform values when rendering the scene with subsequent cameras.