Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeMaterialObserver: Fix buffer resize when transmission is used #29735

Merged
merged 1 commit into from
Oct 23, 2024
Merged

NodeMaterialObserver: Fix buffer resize when transmission is used #29735

merged 1 commit into from
Oct 23, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Oct 23, 2024

Description

It's possible notice when we resize the window in webgpu_loader_gltf_dispersion example.

@sunag sunag marked this pull request as ready for review October 23, 2024 16:45
@sunag sunag added this to the r170 milestone Oct 23, 2024
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 691.57
171.41		 691.57
171.41		 +0 B
+0 B
WebGPU 818.68
220.78		 819.07
220.99		 +390 B
+216 B
WebGPU Nodes 818.19
220.64		 818.58
220.8		 +390 B
+158 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 463.72
112.16		 463.72
112.16		 +0 B
+0 B
WebGPU 539.55
145.72		 539.94
145.85		 +390 B
+134 B
WebGPU Nodes 495.55
135.53		 495.94
135.65		 +390 B
+119 B

@sunag sunag merged commit a2befb6 into mrdoob:dev Oct 23, 2024
12 checks passed
@sunag sunag deleted the dev-observer branch October 23, 2024 17:10
@sunag sunag mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r170
Development

Successfully merging this pull request may close these issues.
1 participant
@sunag