Addons: Add LensflareNode.
#29715
Merged
Addons: Add LensflareNode.
#29715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunag
reviewed
Oct 21, 2024
sunag
reviewed
Oct 21, 2024
| downSampleRatio = 4 | ||
| } = params; | ||
|
|
||
| this.ghostTint = ghostTint; |
There was a problem hiding this comment.
I think we can use ghostTint externally?
const flare = flarePass.mul( color( 0xffffff ) )There was a problem hiding this comment.
It would be good to keep it internally for potential upcoming features. The tint is then processed in a way that produces different results than modulating the entire pass.
This was referenced Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
This PR adds an alternative way to add lens flares to a scene.
The existing
LensflareandLensflareMeshmodules use chained sprites to implement a basic flare effect. This is great but a more advanced approach can be achieved by using post processing. This particular implementation uses the output of bloom to generate flares in the scene. The coupling of bloom and lens flare produces a more natural and plausible look.There are various implementations on the web for implementing FX lens flares. This one uses a vary basic approach based on Chapman's work (linked in the code). The result is already nice but hopefully
LensflareNodecan be improved/enhanced over time.