Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReflectorNode: Added missing nodeObject #29627

Merged
merged 1 commit into from
Oct 11, 2024
Merged

ReflectorNode: Added missing nodeObject #29627

merged 1 commit into from
Oct 11, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Oct 11, 2024

Related issue: #29621

@sunag sunag added this to the r170 milestone Oct 11, 2024
@sunag sunag marked this pull request as ready for review October 11, 2024 22:42
@sunag sunag merged commit 682e2fc into mrdoob:dev Oct 11, 2024
10 of 11 checks passed
@sunag sunag deleted the dev-test-a branch October 11, 2024 22:42
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 689.92
170.93		 689.92
170.93		 +0 B
+0 B
WebGPU 814.71
219.35		 814.71
219.35		 +0 B
+0 B
WebGPU Nodes 814.22
219.22		 814.22
219.22		 +0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.94
111.81		 462.94
111.81		 +0 B
+0 B
WebGPU 537.56
145.04		 537.56
145.04		 +0 B
+0 B
WebGPU Nodes 493.67
134.77		 493.67
134.77		 +0 B
+0 B

@Methuselah96 Methuselah96 mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r170
Development

Successfully merging this pull request may close these issues.
1 participant
@sunag