Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostProcessingUtils: Add getScreenPosition(). #29599

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 9, 2024

Related issue: -

Description

This PR adds getScreenPosition() as a helper to PostProcessingUtils. It also documents the function as well as getViewPosition() so it's more clear what these functions do.

@Mugen87 Mugen87 added this to the r170 milestone Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 689.82
170.9
689.82
170.9
+0 B
+0 B
WebGPU 811.49
218.59
811.63
218.63
+137 B
+39 B
WebGPU Nodes 811
218.46
811.13
218.5
+137 B
+38 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.84
111.78
462.84
111.78
+0 B
+0 B
WebGPU 535.71
144.58
535.71
144.58
+0 B
+0 B
WebGPU Nodes 491.83
134.32
491.83
134.32
+0 B
+0 B

@sunag sunag merged commit e6e4398 into mrdoob:dev Oct 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants