Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LineMaterial: fix segment clipping with reverse depth #29537

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

LineMaterial: fix segment clipping with reverse depth #29537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8183a8a
LineMaterial: fix segment clipping with reverse depth
CodyJasonBennett Oct 1, 2024
749c6cf
LineMaterial: reverse-z correct for half range
CodyJasonBennett Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion examples/jsm/lines/LineMaterial.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,15 @@ ShaderLib[ 'line' ] = {
// conservative estimate of the near plane
float a = projectionMatrix[ 2 ][ 2 ]; // 3nd entry in 3th column
float b = projectionMatrix[ 3 ][ 2 ]; // 3nd entry in 4th column
float nearEstimate = - 0.5 * b / a;

#ifdef USE_REVERSEDEPTHBUF
// - 0.5 * ( - far * near ) / ( far - near )
float nearEstimate = - 0.5 * b;
#else
// - 0.5 * ( ( - 2 * far * near ) / ( far - near ) ) / ( - ( far + near ) / ( far - near ) )
// ( - far * near ) / ( far + near )
float nearEstimate = - 0.5 * b / a;
#endif

float alpha = ( nearEstimate - start.z ) / ( end.z - start.z );

Expand Down