Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL: support uniformArrays from userData() and .label() for userData() and reference() #29430

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

aardgoose
Copy link
Contributor

Added updateReference() method to userDataNode to enable use off array uniforms.
Add label() method to references() to aid debugging shaders.

Also remove redundant method from UniformArrayNode.

support reference().label()
remove duplicate method
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 685.94
169.78
685.94
169.78
+0 B
+0 B
WebGPU 832.7
223.11
832.75
223.12
+50 B
+13 B
WebGPU Nodes 832.21
222.99
832.25
223
+50 B
+13 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.29
111.52
462.29
111.52
+0 B
+0 B
WebGPU 530.17
142.83
530.2
142.85
+35 B
+19 B
WebGPU Nodes 486.82
132.69
486.86
132.71
+35 B
+21 B

@sunag sunag added this to the r169 milestone Sep 17, 2024
@sunag sunag merged commit 915392f into mrdoob:dev Sep 17, 2024
12 checks passed
@aardgoose aardgoose deleted the nodes-1 branch September 18, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants