Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: fix renderGroup.needs update logic #29402

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

aardgoose
Copy link
Contributor

Related issue: #29386

Minor breakage from change in needsUpdate logic.

Note: the performance examples are now broken with the fallback renderer, presumably from the lack of shared UBOs. I'll take a look at that. (only one object in the renderBundle rotates, and only some of the game model objects rotate)

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 685.83
169.75
685.83
169.75
+0 B
+0 B
WebGPU 832.14
222.98
832.13
222.98
-5 B
+1 B
WebGPU Nodes 831.65
222.86
831.64
222.86
-5 B
+2 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.42
111.53
462.42
111.53
+0 B
+0 B
WebGPU 529.9
142.75
529.89
142.75
-5 B
+4 B
WebGPU Nodes 486.56
132.61
486.55
132.62
-5 B
+4 B

@sunag sunag added this to the r169 milestone Sep 13, 2024
@sunag sunag merged commit bf6d895 into mrdoob:dev Sep 13, 2024
12 checks passed
@sunag
Copy link
Collaborator

sunag commented Sep 13, 2024

presumably from the lack of shared UBOs.

I also suspect it's the same thing.

LD2Studio pushed a commit to LD2Studio/LD2Studio-Editor that referenced this pull request Sep 13, 2024
LD2Studio pushed a commit to LD2Studio/LD2Studio-Editor that referenced this pull request Sep 13, 2024
@aardgoose
Copy link
Contributor Author

Confirmed, got a prototype working now.

@aardgoose aardgoose deleted the rb-version branch September 18, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants