Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Fix viewportCoordinate in WebGLBackend #29326

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Sep 5, 2024

Related issue: #29225

Description

Fix viewportCoordinate if used RenderTaget in WebGLBackend.

Copy link

github-actions bot commented Sep 5, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 685.2 kB
169.6 kB
685.2 kB
169.6 kB
+0 B
+0 B
WebGPU 823 kB
220.8 kB
823 kB
220.9 kB
+84 B
+32 B
WebGPU Nodes 822.5 kB
220.7 kB
822.6 kB
220.8 kB
+503 B
+127 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462 kB
111.5 kB
462 kB
111.5 kB
+0 B
+0 B
WebGPU 522.2 kB
140.8 kB
522.3 kB
140.8 kB
+84 B
+30 B
WebGPU Nodes 478.9 kB
130.6 kB
478.9 kB
130.7 kB
-43.26 kB
+29 B

@sunag sunag added this to the r169 milestone Sep 5, 2024
@sunag sunag marked this pull request as ready for review September 5, 2024 01:35
@sunag sunag merged commit 429d6ff into mrdoob:dev Sep 5, 2024
12 checks passed
@sunag sunag deleted the dev-fix-view branch September 5, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant