FBXLoader: Fix incorrect joint orientation for animated FBX models exported from Maya #29307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the rotation for joints on some FBX models from Maya were not being read correctly by
FBXLoader
. These models have both a non-default Euler order and have the "Joint Orient" option set on their joints. The rotation matrix for "Joint Orient" is stored in "PreRotation" in the FBX file andFBXLoader
was erroneously using the Euler order for the regular joint rotation to read it.Example model: WonkyWalk.fbx.zip
Before the fix:
Screen.Recording.2024-09-03.at.10.16.23.AM.mov
After the fix:
Screen.Recording.2024-09-03.at.10.15.38.AM.mov