Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeMaterial: Does not crash if there is no colorNode #29141

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 15, 2024

Description

Does not crash if there is no colorNode in NodeMaterial base class.

@sunag sunag added this to the r168 milestone Aug 15, 2024
@sunag sunag marked this pull request as ready for review August 15, 2024 03:25
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@sunag sunag merged commit 8be7c0f into mrdoob:dev Aug 15, 2024
12 checks passed
@sunag sunag deleted the dev-prevent-crash-nm branch August 15, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant