WebGPURenderer: Enable Subgroup Directives/Builtins #29053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
approved these changes
Aug 5, 2024
sunag
reviewed
Aug 5, 2024
| @@ -645,6 +645,18 @@ ${ flowData.code } | |||
|
|
|||
| } | |||
|
|
|||
| getSubgroupSize() { | |||
|
|
|||
| return this.getBuiltin( 'subgroup_size', 'subgroupSize', 'u32', 'attribute' ); | |||
There was a problem hiding this comment.
I think we could call enableSubGroups() here and getSubgroupIndex()? to add directive automatically..
I think enableDirective() should use Set classe instead of Array.
There was a problem hiding this comment.
That sounds good by me, could probably also do the same for enableExtension if we want default behavior to be the same across extensions ( i.e enable or require )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to generate the subgroup directives and subgroup attributes in WGSLNodeBuilder. Support for enabling the directive and utilizing subgroup builtins will be available in Chrome 128.