Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Rename .getRawShaderAsync() to .getShaderAsync() #29010

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jul 29, 2024

Related issue: #28997 (comment)

@sunag sunag marked this pull request as ready for review July 29, 2024 04:20
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
684 kB (169.4 kB) 684 kB (169.4 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.9 kB (111.2 kB) 460.9 kB (111.2 kB) +0 B

@sunag sunag changed the title WebGPURenderer: Rename .getRawShaderAsync() to .getShaderAsync() WebGPURenderer: Rename .getRawShaderAsync() to .getShaderAsync() Jul 29, 2024
@sunag sunag added this to the r168 milestone Jul 29, 2024
@sunag sunag merged commit 5ce4fa6 into mrdoob:dev Jul 29, 2024
12 checks passed
@sunag sunag deleted the dev-rename-getshaderasync branch July 29, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant