GLTFExporter: Remove unnecessary early return. #28938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent from uneccessary early return
POPOBE97
changed the title
donmccurdy
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
This was intentional as of #12713, to avoid exporting what might be an invalid AnimationClip, but I'm OK with changing as you suggest to skip only the invalid KeyframeTrack, not the entire clip.
Mugen87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary early return
Related issue: No related issues
Description
When deleting nodes within the imported GLB/GLTF model, if the deleted node is referenced by some animation, exporting the GLB again will cause the entire animation track to be discarded, instead of only discarding the animation related to the deleted node. This issue is caused by unnecessary early returns in the
GLTFExporter. Changing thereturnstatements tocontinueresolves this problem.