Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL: Add missing types in wgslFn #28928

Merged
merged 1 commit into from
Jul 21, 2024
Merged

TSL: Add missing types in wgslFn #28928

merged 1 commit into from
Jul 21, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jul 21, 2024

Related issue: Closes #28881

Description

Add missing types in wgslFn

@sunag sunag added this to the r167 milestone Jul 21, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
683.7 kB (169.3 kB) 683.7 kB (169.3 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.9 kB (111.2 kB) 460.9 kB (111.2 kB) +0 B

@sunag sunag marked this pull request as ready for review July 21, 2024 06:24
@sunag sunag merged commit f48f771 into mrdoob:dev Jul 21, 2024
12 checks passed
@sunag sunag deleted the dev-missing-names branch July 21, 2024 06:24
@Spiri0
Copy link
Contributor

Spiri0 commented Jul 21, 2024

Wow, that was worth it. I use all of the three previous textures that were already included extensively. I wouldn't have thought that apart from these, all the others wasn't included.
Looks like the whole range of textures is now covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try using Texture2DArrays with wgslFn leads to errors
2 participants