Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BatchedMesh: Correctly clone data textures. #28805

Merged
merged 1 commit into from
Jul 4, 2024
Merged

BatchedMesh: Correctly clone data textures. #28805

merged 1 commit into from
Jul 4, 2024

Conversation

lanvada
Copy link
Contributor

@lanvada lanvada commented Jul 4, 2024 •
edited by Mugen87
Loading

modified image.slice() to image.data.slice() in BatchedMesh.js

Fixed #28803 .

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
683.4 kB (169.2 kB) 683.5 kB (169.2 kB) +10 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.6 kB (111.1 kB) 460.6 kB (111.1 kB) +0 B

@Mugen87 Mugen87 changed the title modified image.slice() to image.data.slice() in BatchedMesh.js BatchedMesh: Correctly clone data textures. Jul 4, 2024
@Mugen87 Mugen87 added this to the r167 milestone Jul 4, 2024
@Mugen87 Mugen87 merged commit cb1e07a into mrdoob:dev Jul 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r167
3 participants
@lanvada @Mugen87 @zehuahu