MeshBasicNodeMaterial: Add envMap
support.
#28795
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #28785
Description
I thought I give it a go and add
envMap
support toMeshBasicNodeMaterial
.It seems a similar change must be implemented for
MeshLambertNodeMaterial
andMeshPhongNodeMaterial
since both materials types should sample environment maps in the same fashion.BTW:
NodeMaterial
must distinct somehow which materials should useEnvironmentNode
and which should use the code from this PR. Only PBR materials supportScene.environment
and PMREM and that is whatEnvironmentNode
is about.