Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectLoader: Add missing call in parseAsync(). #28777

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 1, 2024

Fixed #28775.

Description

Ensures parseAsync() also calls bindLightTargets() like parse().

@Mugen87 Mugen87 added this to the r167 milestone Jul 1, 2024
@Mugen87 Mugen87 merged commit 1889513 into mrdoob:dev Jul 1, 2024
4 of 5 checks passed
Copy link

github-actions bot commented Jul 1, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
682.2 kB (169 kB) 682.2 kB (169 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
459.4 kB (110.9 kB) 459.4 kB (110.9 kB) +0 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor: Error when loading the json archive with Directional Light
1 participant