CompressedArrayTexture: Rename addLayerUpdates to addLayerUpdate.
#28679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
changed the title
addLayerUpdates to addLayerUpdateaddLayerUpdates to addLayerUpdate.
Mugen87
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there's a typo added in #27972
The documentation describes the new method
addLayerUpdatewhich is correctly added toDataArrayTexturebut is incorrectly namedaddLayerUpdatesinCompressedArrayTexture.Normally I'd be worried about making a backwards incompatible change, however, this feature has only been in the wild for ~2 weeks, is documented under the name
addLayerUpdateand any typescript users will not be able to use the feature at all due to a mismatch between the typescript definition and actual code. Knowing this, I'd recommend we fix the typo.