Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove merge command. #28403

Merged
merged 1 commit into from
May 17, 2024
Merged

CI: Remove merge command. #28403

merged 1 commit into from
May 17, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 17, 2024

Related issue: #28401 (comment)

Description

It seems the CI is reported as failed because the merge command. Trying to remove it to see if it solves the issue.

@Mugen87 Mugen87 merged commit 1a89bb5 into mrdoob:dev May 17, 2024
11 checks passed
@Mugen87 Mugen87 added this to the r165 milestone May 17, 2024
@Mugen87
Copy link
Collaborator Author

Mugen87 commented May 17, 2024

It seems this indeed helps.

So renaming the upload artifact was sufficient when upgrading actions/upload-artifact to v4. The merge command is not required at all.

@mrdoob
Copy link
Owner

mrdoob commented May 17, 2024

Oh I see... 37e1cb5 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants