MMDLoader: Detect model extension from file content. #28266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
changed the title
|
@takahirox I've reviewed the PR as good as possible and everything looks fine to me. The MMD examples work as before. Merging this now but an additional review later on would still be welcome 👍 . |
|
Thanks, I will try to review later when I have time. |
|
I did quickly review and it looks good to me. I may review more details later if I have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, the MMD model extension is detected from URL (code), this approach won't work for blob url because it's like
blob://https://domain/uuid. As the author mentioned, it'll be better to detect it by the file content.How to test
For PMD file testing, please use
examples/webgl_loader_mmd.htmlFor PMX file testing, please use my test branch which includes the asset from Genshin Impact: https://github.com/YusakuNo1/three.js/tree/yusakuno1/detect-mmd-ext-test-pmx