Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fixed non-localized prompt messages #28260

Merged
merged 2 commits into from
May 3, 2024
Merged

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 2, 2024

This PR extracted and translated all the prompt messages, e.g.:

zh.mp4

About the pathname, takes [prompt]/file/open prompt/file/open for example:

  • [prompt] ... the square brackets aims to emphasize that this entry doesn't belong to any real component;
  • /file/open ... the cause that triggers the prompt, in this case 'when opens file';
  • How the prompt gets triggered doesn't matter, e.g. by File>New, Examples>Arkanoid etc

Preview: https://raw.githack.com/ycw/three.js/editor-confirm-msg/editor/index.html

editor/js/Strings.js Outdated Show resolved Hide resolved
@ycw ycw requested a review from Mugen87 May 3, 2024 10:14
@Mugen87 Mugen87 added this to the r165 milestone May 3, 2024
@Mugen87 Mugen87 merged commit f91fe5f into mrdoob:dev May 3, 2024
7 of 11 checks passed
@ycw ycw deleted the editor-confirm-msg branch May 3, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants