Examples: More usage of setAnimationLoop().
#28236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WestLangley
reviewed
Apr 29, 2024
This was referenced Apr 30, 2024
Mugen87
added a commit
to Mugen87/three.js
that referenced
this pull request
May 9, 2024
This reverts commit b8d79b8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #15233
Description
This PR is the first one of a series of PRs that enhances the usage of
setAnimationLoop()in the WebGL examples. This coding pattern was wanted in #15233 and it will also make it easier to migrate existing demos toWebGPURendererat a later point.