Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: Fix global clipping planes with nested render calls. #28120

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 11, 2024

Related issue: #28111

Description

Second attempt to fix #28111. This time, the PR only focuses on restoring the correct state of global clipping planes. Viewport handling is left unchanged.

@Mugen87 Mugen87 added this to the r164 milestone Apr 11, 2024
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
673.1 kB (166.8 kB) 673.2 kB (166.9 kB) +99 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
452.8 kB (109.4 kB) 452.9 kB (109.4 kB) +99 B

@Mugen87 Mugen87 merged commit c8eb9e6 into mrdoob:dev Apr 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect clipping with global clipping planes and nested render calls (e.g. Reflector)
1 participant