Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3MFLoader: Throw error on missing rels. #27955

Merged
merged 2 commits into from
Mar 21, 2024
Merged

3MFLoader: Throw error on missing rels. #27955

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18f0041
THREE.ThreeMFLoader: Throw error on missing rels
nmattia Mar 20, 2024
746237a
Move rels check to loadDocument
nmattia Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions examples/jsm/loaders/3MFLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,8 @@ class ThreeMFLoader extends Loader {

}

if ( relsName === undefined ) throw new Error( 'THREE.ThreeMFLoader: Cannot find relationship file `rels` in 3MF archive.' );

//

const relsView = zip[ relsName ];
Expand Down