Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Improve support int/uint textures #27932

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Mar 17, 2024

Related issue: #27879

Description

Improve support int/uint textures for WGSL.

@sunag sunag added this to the r163 milestone Mar 17, 2024
@Spiri0
Copy link
Contributor

Spiri0 commented Mar 17, 2024

I have now implemented your extensions in r162 and it works fine. I need to take a closer look at all of this to understand it better.
I use this in my virtual texture system

Antares-VT-Texture

This is an older screenshot from a week ago.
Meanwhile it's even better because I've also included the normal maps and calculated the tbn matrix and light. The model is from the internet. The model uvs are not ideal for virtual texturing and the textures could be much higher resolution but it still works very well.

I didn't expect the extension to be so extensive, but it helps me better understand how three.js works. Those were quite a few changes at the deepest level that you made.

@sunag sunag marked this pull request as ready for review March 18, 2024 16:07
@sunag sunag merged commit e6ec298 into mrdoob:dev Mar 18, 2024
11 checks passed
@sunag sunag deleted the dev-i32 branch March 18, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants