Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: Fix connection lengths and let them be based on node input/output types #27891

Merged
merged 8 commits into from
Mar 15, 2024

Conversation

abc013
Copy link
Contributor

@abc013 abc013 commented Mar 9, 2024

Related PR: #27759

Description
Previously, it looked like this:
image
Now, it looks like this:
image

if demanded, i can remove the other (single-connection) colorings as well. Look into #27759 for further discussion.

@sunag
Copy link
Collaborator

sunag commented Mar 10, 2024

Thanks! Why Multiply/Addition output is pink now?

@abc013
Copy link
Contributor Author

abc013 commented Mar 10, 2024

Ah, in- and outputs are pink because they are of the node type. I removed it, we can discuss that particular change in #27759 (and maybe how to retrieve the "real type" of a connection to a socket of type node).

They are now colored in the default color, as it was previously.

@sunag sunag changed the title playground: Fix connection lengths and let them be based on node input/output types Playground: Fix connection lengths and let them be based on node input/output types Mar 15, 2024
@sunag sunag merged commit 9d61527 into mrdoob:dev Mar 15, 2024
11 checks passed
@abc013 abc013 deleted the properLengths branch March 16, 2024 19:17
@WestLangley WestLangley added this to the r163 milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants