WebGLTextures: More flexible image dimensions computation. #27810
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #23164.
Fixed #27783.
Description
The above issues convinced me to make the renderer a bit more flexible in the way it derives image dimensions. This PR introduces a new function in
WebGLTextures
calledgetDimensions()
that derives the image dimensions depending on the image type. Sowidth
andheight
are still the defaults but instances ofHTMLImageElement
now usenaturalWidth
andnaturalHeight
if available. Instances ofVideoFrame
are now supported by usingdisplayWidth
anddisplayHeight
.To minimize the change set,
getDimensions()
is only used at places inWebGLTextures
where instances ofHTMLImageElement
orVideoFrame
can actually occur. So e.g. not in the code paths for data or compressed textures.